Added Hover Effect to all Images#13
Open
Prakarsh-Kaushik wants to merge 3 commits intogdscrgpv:masterfrom
Prakarsh-Kaushik:main
Open
Added Hover Effect to all Images#13Prakarsh-Kaushik wants to merge 3 commits intogdscrgpv:masterfrom Prakarsh-Kaushik:main
Prakarsh-Kaushik wants to merge 3 commits intogdscrgpv:masterfrom
Prakarsh-Kaushik:main
Conversation
meinhoonharsh
requested changes
Oct 11, 2021
Member
meinhoonharsh
left a comment
meinhoonharsh
left a comment
There was a problem hiding this comment.
It's Really great that you've attached Videos to demonstrate what you've did
But the hover Effects are really very quick and not good from a User perspective
.
It would be great If you can add any smooth Transition for it
PS: please fetch the origin again, because some PRs have been merged, It may lead to Merge Conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #5
Things I Did
Before Changes
before.mp4
After Changes
after.mp4