Open
Conversation
Author
|
Issue #5 Untitled.mp4 |
meinhoonharsh
requested changes
Oct 14, 2021
Member
meinhoonharsh
left a comment
meinhoonharsh
left a comment
There was a problem hiding this comment.
You've done a great job, But since we've added another hover effect and this PR is having some conflicts, It would be great, If you can resolve the conflict and Improve the current Hover Effect.
Till then, labelling it as hacktoberfest-accepted so hacktoberfest team can look for this contribution
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "liveServer.settings.port": 5501 | |||
Member
There was a problem hiding this comment.
Never commit any file from .vscode directory or local system configuration files
Author
|
I think now it is resolved. |
Member
|
Could you please attach the GIF of current effect |
Author
|
You are asking for creating a new PR after modifying the current hover effect? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added hover effect on memes