Skip to content

Change Request Commited [For adding Hover Effect]#26

Open
Prakarsh-Kaushik wants to merge 2 commits intogdscrgpv:masterfrom
Prakarsh-Kaushik:new-branch
Open

Change Request Commited [For adding Hover Effect]#26
Prakarsh-Kaushik wants to merge 2 commits intogdscrgpv:masterfrom
Prakarsh-Kaushik:new-branch

Conversation

@Prakarsh-Kaushik
Copy link
Copy Markdown

Issue #5

Things I Did

  • Added meme-img class to all meme images in index.html
    *Added hover effect too .meme-img class
  • Added smooth transition as requested in previous PR review @meinhoonharsh

DEMO

12.10.2021_18.06.08_REC.mp4

Copy link
Copy Markdown
Member

@meinhoonharsh meinhoonharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've done a great job, But since we've added another hover effect and this PR is having some conflicts, It would be great, If you can resolve the conflict and Improve the current Hover Effect.
Till then, labelling it as hacktoberfest-accepted so hacktoberfest team can look for this contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants