Minor enhancements #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Various minor enhancements geared towards ergonomics and performance.
Approach
The big change here is that a
GenBatchercan flush items in a LIFO order. This gives us a minor performance boost because we no longer need to reverse the list of items (which, in some cases, can be rather costly).There is also a minor speed improvement in that we no longer mutate the process dictionary during flushes. This is an incredibly small time save, but it had been bugging me for a while.
Testing
This PR adds new tests for ordering but relies on the existing tests for some of the smaller changes.