Skip to content

Conversation

@StackOverflowExcept1on
Copy link
Member

@StackOverflowExcept1on StackOverflowExcept1on commented Dec 7, 2025

--app seems useless and complicates the implementation, so I removed it. Perhaps we could consider --eth, --client, --no-client.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @StackOverflowExcept1on, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the program_new command in the Rust CLI to streamline the creation of new projects. It removes the previous option to generate only an application package, standardizing the output to a full workspace structure. A key enhancement is the implementation of workspace-level dependency management, where newly generated sub-crates are automatically configured as workspace members, and common dependencies like sails-rs and tokio are defined at the workspace root.

Highlights

  • Workspace Dependency Inheritance: The program_new command now automatically configures newly generated app and client crates as workspace dependencies within the root Cargo.toml. This includes removing redundant package metadata from sub-crates and adding a descriptive entry.
  • Removal of --app Flag: The --app flag, which previously allowed generating only an application package, has been removed. The program_new command now consistently generates a full workspace structure including root, app, client, build, and test packages.
  • Standardized Dependency Management: Common dependencies like sails-rs and tokio are now managed at the workspace level in the root Cargo.toml, simplifying dependency declarations across the project.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the program_new command to consistently generate a workspace structure, leveraging dependency inheritance. This is a good simplification, removing the --app flag and its associated conditional logic. However, there is a critical issue where the generated workspace's Cargo.toml does not have its members field populated, which will cause cargo commands to fail. I've provided a suggestion to fix this. Additionally, I've noted a medium-severity issue regarding a hardcoded dependency version.

@vobradovich
Copy link
Member

got error on windows

error: could not parse override file: 'E:\my-demo2\rust-toolchain.toml': error parsing override file: TOML parse error at line 4, column 1
  |
4 |
  | ^

fixed with

[toolchain]
channel = "stable"
targets = ["wasm32-unknown-unknown", "wasm32v1-none"]
{{- "\n" -}}

@StackOverflowExcept1on
Copy link
Member Author

@vobradovich I had problem where I needed to add \n\n to the .askama files because for some reason this template engine ignored just one \n so the last line would be empty

@vobradovich
Copy link
Member

@vobradovich I had problem where I needed to add \n\n to the .askama files because for some reason this template engine ignored just one \n so the last line would be empty

{{- "\n" -}}

works on both Windows and Linux

@StackOverflowExcept1on StackOverflowExcept1on merged commit f157305 into master Dec 18, 2025
4 checks passed
@StackOverflowExcept1on StackOverflowExcept1on deleted the av/sails-cli-inherit-workspace branch December 18, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants