Skip to content

Conversation

@vobradovich
Copy link
Member

No description provided.

@vobradovich vobradovich self-assigned this Dec 18, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @vobradovich, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a minor but important maintenance update to the codebase. It modifies the macro generation logic to use the #[allow(unused)] attribute instead of #[allow(unused_variables)]. This adjustment is necessary to align with a new lint introduced in Clippy 1.92, preventing warnings and keeping the generated code clean and up-to-date with current Rust best practices.

Highlights

  • Clippy Lint Fix: Updated the #[allow(unused_variables)] attribute to the more general #[allow(unused)] in generated Rust code.
  • Compatibility: This change addresses a new lint introduced in Clippy version 1.92, ensuring the codebase remains compatible with the latest linter rules.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the generated Rust code by changing the #[allow(unused_variables)] attribute to the more general #[allow(unused)] within the topics and data methods of EthEvent implementations. This modification is applied in the generate_eth_event_impl macro and is reflected in several snapshot test files. No review comments were provided.

@vobradovich vobradovich merged commit 7024610 into master Dec 18, 2025
4 checks passed
@vobradovich vobradovich deleted the vo/clippy-1.92 branch December 18, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants