Challenge: ZAIRIyoussef submission#82
Open
ZAIRIyoussef wants to merge 2 commits intogeeksblabla:mainfrom
Open
Conversation
Collaborator
|
I think there is something wrong with your submission :) you forgot what the file extension 😅 |
aboullaite
reviewed
Feb 22, 2024
| @@ -0,0 +1,44 @@ | |||
| import csv | |||
| from collections import defaultdict | |||
Collaborator
There was a problem hiding this comment.
are these imports from standard python libraries ?
Contributor
There was a problem hiding this comment.
@aboullaite, I'm answering on Youssef's behalf, yes, both are part of the standard Python library
aboullaite
reviewed
Feb 24, 2024
| prix_par_ville = defaultdict(float) | ||
| prix_par_produit_et_ville = defaultdict(lambda: defaultdict(list)) | ||
|
|
||
| with open(chemin_fichier, newline='', encoding='utf-8') as csvfile: |
Collaborator
There was a problem hiding this comment.
Wouldn't this load the whole file in memory ? If yes, it's likely to trigger an OOM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.