-
Notifications
You must be signed in to change notification settings - Fork 7
Add status command, validation script, troubleshooting guide, and CI/CD (fixes #2) #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add /ralph:status command to check loop state - Add validation script to verify prerequisites - Support --flag=value argument format in setup.sh - Add TROUBLESHOOTING.md guide for common issues - Add GitHub Actions workflow for automated testing - Add status command tests - Add version bump utility script - Enhance help command with examples - Update README with new features and validation steps
- Ensures original_prompt in state.json doesn't include the command prefix - Fixes Test 4 failure in setup_test.sh - All tests now pass successfully
Summary of ChangesHello @surajsahani, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Ralph extension by introducing new features focused on user experience, debugging, and maintainability. It adds a status command for real-time loop monitoring, a validation script to ensure proper setup, and a detailed troubleshooting guide to assist users with common problems. Furthermore, it improves argument parsing for loop commands and includes a utility for version management. A key fix addresses a bug related to prompt parsing, ensuring the core loop functionality operates as expected. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant set of features that improve the usability and robustness of the Ralph extension, including a status command, a validation script, and a troubleshooting guide. The code is generally well-written and the new features are implemented correctly. The fix for the prompt parsing also addresses a key bug. I have a few suggestions to enhance the scripts further: one critical fix in the bump-version.sh script to prevent potential data loss, a couple of medium-severity suggestions to make documentation and validation scripts more platform-agnostic, and a note on improving test structure for better isolation.
- Fix critical data loss issue in bump-version.sh by checking jq exit code - Make jq installation instructions platform-agnostic in TROUBLESHOOTING.md - Update validate.sh with multi-platform installation instructions
- Call cleanup before each test to ensure clean state - Prevents test interdependencies and improves reliability - Follows best practice of explicit setup/teardown per test
This PR re-introduces the improvements from #7 with the test failure fixed.
Changes
/ralph:statuscommand to check loop state--flag=valueargument format in setup.shFix
/ralph:loopprefix from stored prompt to fix Test 4 failureRelated
Testing
All test suites pass:
bash tests/setup_test.sh✅bash tests/hook_test.sh✅bash tests/status_test.sh✅