finish teats #7
Open
finish teats #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemtechd
requested changes
Jul 14, 2025
Owner
gemtechd
left a comment
gemtechd
left a comment
There was a problem hiding this comment.
See one comment below that is one for all the cases
you still have to write the tests for the geometry-calculation file
…emselves and removed the calls from the test
gemtechd
reviewed
Jul 15, 2025
Owner
gemtechd
left a comment
gemtechd
left a comment
There was a problem hiding this comment.
don't push comments to the repo
|
|
||
|
|
||
| calculateNOfLineFunction() { | ||
| this.calculateSlope(); // הוספת קריאה כאן |
|
|
||
| it('should get point on X axis correctly', () => { | ||
| line.calculateNOfLineFunction(); | ||
| const pointOnX = line.getPointOnXAsis(); |
Owner
There was a problem hiding this comment.
execute only one function on each test
this comment is for all the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name:Ety Konski
I finished task1.