create tests #18
Open
create tests #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemtechd
reviewed
Jul 23, 2024
| throw new Error('missing data') | ||
| } | ||
| if(typeof(point1)!= 'object' |typeof(point2)!='object'){ | ||
| throw new Error('argument must by type point') |
Owner
There was a problem hiding this comment.
write a test that gets an array
| if(line1==undefined || line2==undefined){ | ||
| throw new Error("missing data") | ||
| } | ||
| if (line1.slope === line2.slope) { |
Owner
There was a problem hiding this comment.
what happens if the slope of line1 or line2 are not defined?
| throw new Error("missing data") | ||
| } | ||
| const proxyLine = new Line({ point1: line.point1, point2: point }) | ||
| proxyLine.calculateSlope() |
Owner
There was a problem hiding this comment.
what happens when line.slope or line.n are undefined?
Owner
|
I can't see any test files... |
Author
|
i am confused and do not understand what the problem .
i got feedback on my code and now i am working on it.
thanks -
shifra berkovich-silberberg
בתאריך יום ג׳, 23 ביולי 2024 ב-11:04 מאת gemtechd <
***@***.***>:
… I can't see any test files...
What do you see from your user?
—
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BJ5PY6ACVIN6Y56OPU2E5UDZNYFBNAVCNFSM6AAAAABLJWPLDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBUGUZDSNZZGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
I saw only the code to giv eyou feedback on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.