my tests #35
my tests #35
Conversation
|
I have tried a lot of ways to mock the class line while having the option to change the values of n and slope in the ctor. |
gemtechd
left a comment
gemtechd
left a comment
There was a problem hiding this comment.
Update your code
the tests weren't reviewed now
| // }) | ||
| // }; | ||
| // }); | ||
|
|
| constructor({ point1 = new Point(), point2 = new Point(), n = undefined, slope = undefined }) { | ||
| constructor({ point1 = new Point(), point2 = new Point(), n = undefined, slope = undefined }={}) { | ||
| if(!(point1 instanceof Point) || !(point2 instanceof Point)){ | ||
| throw new Error('points must be instances of point') |
|
|
||
| calculateSlope = () => { | ||
| calculateSlope () { | ||
| this.slope = (this.point1.y - this.point2.y) / (this.point1.x - this.point2.x) |
There was a problem hiding this comment.
did you check that the x for both points are not identical? =>should divide by zero
|
|
||
| calculateNOfLineFunction = () => { | ||
| calculateNOfLineFunction(){ | ||
| this.n = this.point1.y - this.slope * this.point1.x |
| getPointByX(x) { | ||
| getPointByX(x=0) { | ||
| if(typeof(x)!='number'){ | ||
| throw new Error('value must be a number') |
| if(typeof(x)!='number'){ | ||
| throw new Error('value must be a number') | ||
| } | ||
| let y = this.slope * x + this.n |
| if(typeof(y)!='number'){ | ||
| throw new Error('value must be a number') | ||
| } | ||
| let x = (y - this.n) / this.slope; |
There was a problem hiding this comment.
are the n and the slope calculated?
| throw new Error('must enter 2 lines') | ||
| if(!(line2 instanceof Line)||!(line1 instanceof Line)) | ||
| throw new Error('lines must be instances of Line') | ||
| if (line1.slope === line2.slope) { |
| if(! (line instanceof Line)) | ||
| throw new Error('line must be instance of Line') | ||
| const proxyLine = new Line({ point1: line.point1, point2: point }) | ||
| proxyLine.calculateSlope() |
| "coverage":"npm test -- --coverage" | ||
| }, | ||
| "dependencies": { | ||
| "jest": "^29.7.0" |
There was a problem hiding this comment.
this is really not the good place
2 participants
No description provided.