-
Notifications
You must be signed in to change notification settings - Fork 41
add tests almost finished #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
merge main with tests in the first time |
gemtechd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update the code also
because the code misses some checks before the tests
|
I know that, I wrote that by myself, yesterday I asked you to give me the
next task, although I have not finished yet.
בתאריך יום ג׳, 6 באוג׳ 2024 ב-19:39 מאת gemtechd <
***@***.***>:
… ***@***.**** commented on this pull request.
You need to update the code also
because the code misses some checks before the tests
—
Reply to this email directly, view it on GitHub
<#40 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKE5TX7JSNIICS3QF7QIYJTZQD35TAVCNFSM6AAAAABMCGBWKOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMRRG44TCMJTHA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
|
Ok, I'll check it out.
בתאריך יום ד׳, 7 באוג׳ 2024 ב-10:22 מאת gemtechd <
***@***.***>:
…
1. everyone wrote the task, and every girl got the review the same way
2. You need to make better the code, for example check the code that
the function got all parameters
3. You need to go through the first task with a little bit frustration
that the next task you'll be on the right path from the beginning,
4. btw you were invited a long time ago to the github - this things
are up to you
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKE5TXYVJX74QAXJ37HTM3DZQHDJ3AVCNFSM6AAAAABMCGBWKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZSG44TKMJQGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
I made a new commit , but I don't see that in the pull requests, only in mine. |
|
Send it to a PR |
No description provided.