Conversation
Add oxlint for linting, oxfmt for formatting, and knip for dead code detection. Fix all existing lint issues and auto-format codebase. - Add oxlintrc.json with sensible rules (eqeqeq, no-var, no-eval, etc.) - Add .oxfmtrc.json for consistent formatting (4-space, double quotes, 120 width) - Add knip.json for dead code detection - Add just lint/format/format-check/dead-code/check commands - Fix eqeqeq violations, unused imports, prefer-const, prefer-as-const - Remove redundant console.error calls in provider catch blocks - Exclude generated packages/types/src/primitives from all tools
Summary of ChangesHello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a robust set of linting and formatting tools, including oxlint, oxfmt, and knip, to enforce consistent code style and identify unused code throughout the monorepo. It updates development guidelines and integrates these tools into the build system, aiming to significantly improve code maintainability, readability, and overall quality. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces linting and formatting tools (oxlint, oxfmt, knip) to the project, which is a great step towards improving code quality and consistency. The configuration for these tools is well-defined, and many files have been reformatted accordingly.
My main feedback is about the removal of several console.warn and console.error calls, likely to satisfy the new no-console linting rule. While cleaning up console logs is generally good, in some cases, these logs provided important information for debugging failures (e.g., API errors, silent fallbacks to default values). I've left a few comments suggesting to re-introduce logging in critical error paths to maintain observability, possibly using lint-disable comments as a temporary measure.
1 participant
No description provided.