Skip to content

Add okx provider icon#1698

Merged
gemcoder21 merged 2 commits intomainfrom
okx
Feb 16, 2026
Merged

Add okx provider icon#1698
gemcoder21 merged 2 commits intomainfrom
okx

Conversation

@0xh3rman
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily integrates the OKX swap provider into the application, encompassing the addition of its identifier to the SwapProvider enum and the inclusion of its corresponding icon assets. This allows the application to recognize and display the OKX provider's icon. Additionally, a minor update was made to handle Tron transactions with a temporary fatalError() and the core submodule was updated to its latest version.

Highlights

  • OKX Provider Integration: The okx swap provider has been added to the system, enabling its recognition and use within the application.
  • Icon Assets Added: New image assets for the okx provider, including its SVG icon and associated metadata, have been included in the project's resources.
  • Image Mapping Updated: The SwapProviderType+Gemstone extension now correctly maps the okx provider to its newly added icon, ensuring proper display.
  • Tron Transaction Handling: A placeholder fatalError() case for .tron transactions was added in WalletConnectTransaction+ChainServices.swift.
  • Core Submodule Updated: The core submodule dependency has been updated to its latest commit, reflecting upstream changes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Packages/ChainServices/WalletConnectorService/Extensions/WalletConnectTransaction+ChainServices.swift
    • Added a fatalError() case for .tron to the WalletConnectTransaction extension's mapToChainService function.
  • Packages/Primitives/Sources/SwapProvider.swift
    • Added the okx case to the SwapProvider enum.
  • Packages/PrimitivesComponents/Sources/Extensions/SwapProviderType+Gemstone.swift
    • Extended SwapProvider to return the okx image for the okx case.
  • Packages/Style/Sources/Images.swift
    • Introduced a static okx property within Images.SwapProviders to reference the new image asset.
  • Packages/Style/Sources/Resources/Assets.xcassets/swap_providers/okx.imageset/Contents.json
    • Created a JSON file defining the okx.svg as an image asset.
  • Packages/Style/Sources/Resources/Assets.xcassets/swap_providers/okx.imageset/okx.svg
    • Added the SVG vector graphic for the OKX logo.
  • core
    • Updated the core submodule reference to a newer commit.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the OKX provider icon and its related assets across the project. The changes related to the new icon are correct. However, there is an unrelated change in WalletConnectTransaction+ChainServices.swift that introduces a fatalError() for Tron transactions. This is a critical issue that will cause the app to crash and must be addressed before this pull request is merged.

case .sui(let data, let outputType): .sui(data.transaction, outputType.map())
case .ton(let messages, let outputType): .ton(messages, outputType.map())
case .bitcoin(let data, let outputType): .bitcoin(data, outputType.map())
case .tron: fatalError()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Using fatalError() will cause the application to crash if it ever processes a Tron transaction. This is a critical risk to application stability. Since this change appears to be unrelated to the main purpose of this pull request (adding an OKX provider icon), it's important to handle this case safely. Please either fully implement the mapping for .tron or remove this change from this PR to be addressed separately. Merging unimplemented feature paths that result in a crash is not safe.

@gemcoder21 gemcoder21 merged commit 48d59fb into main Feb 16, 2026
1 check passed
@gemcoder21 gemcoder21 deleted the okx branch February 16, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants