Pnl subtitle offset fix

[gemdev111]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @gemdev111, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue with the PnL subtitle image offset by simplifying its calculation within the WalletHeaderViewModel. The change ensures a consistent offset value, improving the visual presentation of the PnL indicator.

Highlights

• PnL Subtitle Image Offset: The logic for the subtitleImageOffset property in WalletHeaderViewModel has been simplified to always return a fixed value of 1.
• Code Simplification: Removed conditional logic that previously determined the subtitleImageOffset based on the PnL amount, streamlining the view model.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• Packages/PrimitivesComponents/Sources/ViewModels/WalletHeaderViewModel.swift
  • Simplified the subtitleImageOffset property to a fixed value.
  • Removed the conditional logic for subtitleImageOffset.

Activity

• No activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request simplifies the logic for the subtitle image offset in the WalletHeaderViewModel by replacing a conditional switch statement with a constant value. This appears to be a fix for a UI alignment issue, and it makes the code more concise. My feedback includes a suggestion to add a comment to improve the clarity of the new hardcoded value for future maintenance.

[gemini-code-assist]

This change simplifies the logic by using a constant offset. However, the value 1 is a 'magic number'. To improve code clarity and maintainability for future developers, please consider adding a comment explaining its purpose, which appears to be for vertical alignment.

Suggested change

	public var subtitleImageOffset: CGFloat { 1 }
	public var subtitleImageOffset: CGFloat { 1 } // Vertical offset for alignment