Fix zero balances for discovered assets

[DRadmir]

Remove shouldRefresh parameter from AssetsEnabler - always refresh balances and prices when enabling assets. The parameter was introduced to avoid duplicate addPrices calls, but it also skipped balance updates for newly discovered assets (osmosis, ton, injective, etc.).

Changes:

• Remove shouldRefresh from AssetsEnabler protocol and extension
• AssetsEnablerService.enableAssets always updates balances/prices when enabled
• WalletAssetSyncService.discoverAssets uses default enableAssets behavior
• Remove redundant addPrices call before enableAssets

Fix: #1706

[gemini-code-assist]

Summary of Changes

Hello @DRadmir, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where newly discovered assets would display zero balances because their balances and prices were not being refreshed upon enablement. By removing the shouldRefresh parameter from the AssetsEnabler protocol and its implementations, the system now consistently refreshes asset balances and prices whenever assets are enabled, ensuring accurate display for all assets.

Highlights

• shouldRefresh parameter removal: The shouldRefresh parameter has been removed from the AssetsEnabler protocol and its implementations, simplifying the asset enabling logic.
• Balance and price refresh logic: The AssetsEnablerService.enableAssets function now unconditionally triggers balance and price updates when assets are enabled, resolving issues with zero balances for newly discovered assets.
• Redundant addPrices call: A redundant addPrices call in WalletAssetSyncService.discoverAssets was removed, as the enableAssets function now handles price updates.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• Packages/FeatureServices/WalletsService/AssetsEnablerService.swift
  • Removed shouldRefresh parameter from enableAssets function signature.
  • Adjusted guard condition to always trigger balance and price updates if assets are enabled.
  • Updated enableAssetId to call enableAssets without shouldRefresh.
• Packages/FeatureServices/WalletsService/Protocols/AssetsEnabler.swift
  • Removed shouldRefresh parameter from the enableAssets protocol definition.
  • Removed the default extension implementation for enableAssets.
• Packages/FeatureServices/WalletsService/WalletAssetSyncService.swift
  • Removed the shouldRefresh: false argument from the assetsEnabler.enableAssets call.
  • Removed the redundant addPrices call before enabling assets.
• Packages/FeatureServices/WalletsService/WalletsService.swift
  • Updated the enableAssets forwarding method to match the new signature without shouldRefresh.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses the issue of zero balances for newly discovered assets by removing the shouldRefresh parameter from the AssetsEnabler logic. This ensures that balances and prices are always refreshed when assets are enabled. The changes simplify the codebase by removing conditional logic and a redundant addPrices call in WalletAssetSyncService. The implementation is clean and directly solves the reported problem. The code modifications across AssetsEnablerService, AssetsEnabler protocol, WalletAssetSyncService, and WalletsService are consistent and well-executed.