Implemented new is_appellate_case verifier for legal applications, ad… #200
Conversation
…ded JSON files for testing
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Enforce conventional commitThis rule is failing.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
There was a problem hiding this comment.
Both this file and the case metadata used for testing should be moved into the test/ directory.
|
|
||
| def is_appellate_court(court_name): | ||
| lowered_name = court_name.lower() | ||
| exceptions = ["pennsylvania superior court", "pennsylvania commonwealth court"] |
There was a problem hiding this comment.
please document this. Why are these exceptions and how are they handled?
|
|
||
|
|
||
| def get_court_from_case(case_name, folder_path): | ||
| files = os.listdir(folder_path) |
There was a problem hiding this comment.
Operate over strings, not files, in the stdlib.
There was a problem hiding this comment.
Hi @hannahTao; can you please make sure you also have the pre-commit hooks installed. You should just need to run pre-commit install (maybe uv pip install pre-commit first as well). You should see some issues when committing because we have requirements for docstrings and things like that.
For your case metadata, this should also be moved to the test directory. However, can you please move it to test/data/legal/nj_case_metadata/*?
…ON files as list of dict, added docstrings and typing
…n both functions and tests
3 participants
…ded JSON files for testing