feat: MelleaSession.register for functional interface and MelleaSession.powerup for dynamic mixin (register all methods in a class) #224
+288
−706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
guicho271828
force-pushed
the
powerups
branch
2 times, most recently
from
e3a996d to
98703d1
Compare
guicho271828
force-pushed
the
powerups
branch
from
98703d1 to
83b699a
Compare
jakelorocco
reviewed
Nov 5, 2025
Contributor
jakelorocco
left a comment
jakelorocco
left a comment
There was a problem hiding this comment.
Not sure if these are just issues with my type-hinter / the default one in VSCode.
It may not be possible to dynamically create these methods while retaining basic intellisense and type hinting.
Comment on lines
+38
to
+44
| DOCS = { | ||
| # from `act` | ||
| "action": "the Component from which to generate.", | ||
| "context": "the context being used as a history from which to generate the response.", | ||
| "backend": "the backend used to generate the response.", | ||
| # "requirements": "used as additional requirements when a sampling strategy is provided.", | ||
| "strategy": "a SamplingStrategy that describes the strategy for validating and repairing/retrying for the instruct-validate-repair pattern. None means that no particular sampling strategy is used.", |
Contributor
There was a problem hiding this comment.
Even though it's repetitive, I would prefer leaving the docstrings as a part of each function:
- it's easier to see what's going on when you look at the function
- the docstrings don't appear in my function preview:
- I'm not sure how this interacts with our docs page tooling (or future versions of it)
Comment on lines
+307
to
+319
| MelleaSession.register(mfuncs.act) | ||
| MelleaSession.register(mfuncs.instruct) | ||
| MelleaSession.register(mfuncs.chat) | ||
| MelleaSession.register(mfuncs.validate, set_context=False) | ||
| MelleaSession.register(mfuncs.query) | ||
| MelleaSession.register(mfuncs.transform) | ||
|
|
||
| MelleaSession.register(mfuncs.aact) | ||
| MelleaSession.register(mfuncs.ainstruct) | ||
| MelleaSession.register(mfuncs.achat) | ||
| MelleaSession.register(mfuncs.avalidate, set_context=False) | ||
| MelleaSession.register(mfuncs.aquery) | ||
| MelleaSession.register(mfuncs.atransform) |
Contributor
There was a problem hiding this comment.
This bricks all type-hinting / intellisense for me in VSCode. I don't even see m.instruct or m.<>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.