Add Property and Field symbol extraction to DocumentSymbol #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement dual-mode DocumentSymbol provider supporting both LSP 2.x flat mode (SymbolInformation) and LSP 3.x hierarchical mode (DocumentSymbol with children). Changes: - Add TSymbolMode enum and TSymbolBuilder class for dual-mode building - Detect client hierarchicalDocumentSymbolSupport capability during init - Build hierarchical structure with parent-child relationships - Return DocumentSymbol (with range/children) or SymbolInformation (with location/containerName) based on client capability Benefits: - Better IDE integration (Outline view shows proper nesting in VS Code) - Enables hierarchical navigation and symbol search (Class/Method paths) - Backward compatible with clients not supporting hierarchical mode - Compliant with LSP 3.10+ specification Tested with VS Code and Serena MCP, both working correctly in hierarchical mode with proper symbol nesting.
zen010101
force-pushed
the
feat/property-field-symbols
branch
from
2850f9b to
ef2bb5b
Compare
- Implemented extraction of Property symbols (SymbolKind.Property = 7) - Implemented extraction of Field symbols (SymbolKind.Field = 8) - Both flat and hierarchical modes are supported - Added FPCUnit test suite (Tests.DocumentSymbol) with comprehensive coverage - Tests verify correct extraction of Class, Property, Field, and Method symbols The implementation properly handles both SymbolInformation (flat) and DocumentSymbol (hierarchical) response formats based on client capabilities.
zen010101
force-pushed
the
feat/property-field-symbols
branch
from
ef2bb5b to
1f9d7fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
TSymbolExtractor.Extractto handle Property and Field declarationsTest Coverage
Testing
Run tests:
Results: