Open
Conversation
Open
dadukhankevin
force-pushed
the
daniel/mehga
branch
from
736129c to
64cc8b8
Compare
- Add optional `id` field to all edit history types (EditHistoryBase, EditFor, etc.)
- Add `CellValueOnDisk` type: `{ selectedEdit, updatedAt }` for on-disk cell values
- Add `activeEditId` to cell metadata and QuillCellContent for O(1) edit lookup
- Add `generateEditId()` using SHA-256 via existing uuidUtils
- Add `resolveCellValue()` helper for reading raw .codex JSON safely
- Serializer bridge: deserialize resolves object→string, serialize writes string→object
- Merge dedup uses edit `id` as primary key (composite fallback for legacy)
- `applyEditToCell` saves value as `{ selectedEdit, updatedAt }` when edit has id
- CodexDocument: all new edits get `id: randomUUID()`, sets `activeEditId`
- New `selectEdit(cellId, editId)` method for rollbacks preserving validations
- `getCellValueData` does O(1 lookup by activeEditId with scan fallback
- Migration `migration_editValueObject`: backfills IDs, converts cell.value to object
- Updated raw-JSON touchpoints (matcher, updater, cellUtils, sharedUtils)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update test assertions to handle CellValueOnDisk object format on disk: - codexCellEditor.test.ts: check edit value via selectedEdit lookup - codexCellEditorProvider.test.ts: same pattern for disk persistence - editMapUtils.test.ts: duplicate edit needs same id for dedup - providerMergeResolve.test.ts: merged cell.value is now an object Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CodexCellDocument reads .codex files directly via JSON.parse, bypassing
the serializer. When cell.value is saved as { selectedEdit, updatedAt }
on disk, the constructor needs to resolve it to a string just like the
serializer does, otherwise downstream code breaks.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dadukhankevin
force-pushed
the
daniel/mehga
branch
2 times, most recently
from
dbafc52 to
960b6a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.