Open
Conversation
- Pass language code (lang param) to ASR endpoint for better transcription quality - Include language in getAsrConfig response from extension to webview - Add "Transcribe All" button alongside per-cell "Transcribe" to encourage batching - Reuse single WhisperTranscriptionClient across batch to leverage warmed Modal container - Default batch command to "all untranscribed cells" instead of requiring count - Show cold-start warning (~45s) in transcription info messages - Save actual language code instead of "unknown" in transcription metadata Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ignment (#429) When importing a translation, the cell aligner correctly matches cells by cellLabel (e.g. "GEN 1:1"), but handleWriteTranslation was using the imported content's newly-generated UUID instead of the matched target cell's existing UUID. This broke source-to-target linkage because the target cells ended up with different IDs than their source counterparts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tests confirm the aligner matches by cellLabel and returns existing target cell IDs, and that the handleWriteTranslation ID resolution logic correctly prefers the matched notebook cell ID over the imported content's newly-generated UUID. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleWriteTranslationwas using the imported content's newly-generated UUID instead of the matched target cell's existing UUID, breaking source-to-target linkageNewSourceUploaderProvider.tsto use the matched notebook cell's ID (alignedCell.notebookCell.metadata.id) with fallback to imported content IDusfmCellAlignerverifying correct ID resolutionTest plan
Fixes #429
🤖 Generated with Claude Code