684 search and replace v2 fixes and improvements#738
684 search and replace v2 fixes and improvements#738Luke-Bilhorn wants to merge 9 commits intomainfrom
Conversation
…SearchBar now scrolls both windows in sync to cylce between search results.
… result when clicked.
|
I merged this in with a conflict, now going to go test. |
|
This merge broke stuff. Closing this PR until I fix it. |
|
Ok, so the merge actually did not break stuff. What happened was that I thought I could safely keep all of the edits from main and my branch in Comments View, and then when I tested it I got build errors. I kinda panicked and reverted it, but then when I worked through the whole thing on a couple other branches I realized that it was just a package issue on my machine. So, I reapplied the merge and tested it, and it all works now so far as I can find. |
LeviXIII
left a comment
There was a problem hiding this comment.
I think you will have to cherry pick the changes that only pertain to the search and replace. This PR undoes the improvements to the comments, so it looks like your merge went bad.
Besides that, the search and replace is working better. A couple of things to change still:
- When searching, only the target text gets highlighted and not the source
- When clicking on the result card, I do get highlighted text which is good, but every time I click another cell in the target the result card cell still gets highlighted.
Screen.Recording.2026-03-12.at.8.00.00.AM.mov
- We should change the 1 of 14 of 55 to something more coherent. I'm thinking that there are 55 different milestones with the word, so maybe we can convey that differently. Like 1 to 14 - Page 1?
Added these 3 fixes that Matt requested!
I'll get the one Ben asked for in a little bit.