Skip to content

684 search and replace v2 fixes and improvements#738

Open
Luke-Bilhorn wants to merge 9 commits intomainfrom
684-search-and-replace-v2-fixes-and-improvements
Open

684 search and replace v2 fixes and improvements#738
Luke-Bilhorn wants to merge 9 commits intomainfrom
684-search-and-replace-v2-fixes-and-improvements

Conversation

@Luke-Bilhorn
Copy link
Copy Markdown
Contributor

Added these 3 fixes that Matt requested!

I'll get the one Ben asked for in a little bit.

@Luke-Bilhorn Luke-Bilhorn linked an issue Mar 11, 2026 that may be closed by this pull request
@Luke-Bilhorn
Copy link
Copy Markdown
Contributor Author

I merged this in with a conflict, now going to go test.

@Luke-Bilhorn
Copy link
Copy Markdown
Contributor Author

This merge broke stuff. Closing this PR until I fix it.

…improvements"

This reverts commit be4ef5f, reversing
changes made to d5a752d.
@Luke-Bilhorn Luke-Bilhorn reopened this Mar 12, 2026
@Luke-Bilhorn
Copy link
Copy Markdown
Contributor Author

Ok, so the merge actually did not break stuff.

What happened was that I thought I could safely keep all of the edits from main and my branch in Comments View, and then when I tested it I got build errors. I kinda panicked and reverted it, but then when I worked through the whole thing on a couple other branches I realized that it was just a package issue on my machine. So, I reapplied the merge and tested it, and it all works now so far as I can find.

Copy link
Copy Markdown
Contributor

@LeviXIII LeviXIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you will have to cherry pick the changes that only pertain to the search and replace. This PR undoes the improvements to the comments, so it looks like your merge went bad.

Besides that, the search and replace is working better. A couple of things to change still:

  1. When searching, only the target text gets highlighted and not the source
Image
  1. When clicking on the result card, I do get highlighted text which is good, but every time I click another cell in the target the result card cell still gets highlighted.
Screen.Recording.2026-03-12.at.8.00.00.AM.mov
  1. We should change the 1 of 14 of 55 to something more coherent. I'm thinking that there are 55 different milestones with the word, so maybe we can convey that differently. Like 1 to 14 - Page 1?
Image

@LeviXIII
Copy link
Copy Markdown
Contributor

#745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search and Replace V2 - Fixes and improvements

2 participants