Open
Conversation
…gration utilities and tests - Removed legacy mapping of "ebiblecorpus" to "ebible" and updated to preserve "ebibleCorpus" as a distinct FileImporterType. - Adjusted related tests to reflect the new standardization, ensuring consistency in importerType assertions. - Updated documentation to clarify the changes in standardization rules for importer types.
…uage metadata retrieval - Updated language metadata retrieval in WelcomeViewProvider and MetadataManager to use optional chaining for projectStatus checks, preventing potential runtime errors when accessing properties of undefined objects. - Enhanced test suite for NotebookMetadataManager to include a timeout for improved stability during CI runs. - Added stubs in SyncManager tests to prevent guards from blocking version checks and ensure smoother test execution.
Luke-Bilhorn
approved these changes
Mar 31, 2026
Contributor
Luke-Bilhorn
left a comment
Luke-Bilhorn
left a comment
There was a problem hiding this comment.
Nothing is broken when I use the ebible importer.
Nothing looks out of place from a cursory glance over the code.
dadukhankevin
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revert change that was not necessary and might cause issues