778 if a vtt or srt file is not valid in some way we should give a warning during import#820
Merged
Luke-Bilhorn merged 6 commits intodevfrom Mar 31, 2026
Conversation
When time stamps are not sequential and currupted, user will be notified with yellow box stating the problem with the file during the import process. The user may still proceed.
…-way-we-should-give-a-warning-during-import
BenjaminScholtens
approved these changes
Mar 31, 2026
Collaborator
BenjaminScholtens
left a comment
BenjaminScholtens
left a comment
There was a problem hiding this comment.
looks good works good
BenjaminScholtens
requested changes
Mar 31, 2026
Collaborator
BenjaminScholtens
left a comment
BenjaminScholtens
left a comment
There was a problem hiding this comment.
let's just make it give a warning any time things are out of order.
- Removed the OUT_OF_ORDER_THRESHOLD_SECONDS constant and adjusted the logic to flag any backward jumps in timestamps. - Improved formatting of warning messages for better readability. - Ensured that the validation function continues to provide accurate warnings for non-sequential timestamps in subtitle files.
- Changed the test case description to clarify that it now catches small overlaps from multi-speaker cues instead of ignoring them.
- Updated the test to check for specific warnings related to non-sequential timestamps, ensuring it captures cases with significant overlaps in speaker cues.
BenjaminScholtens
approved these changes
Mar 31, 2026
Collaborator
BenjaminScholtens
left a comment
BenjaminScholtens
left a comment
There was a problem hiding this comment.
looks good works good
…-way-we-should-give-a-warning-during-import
Luke-Bilhorn
approved these changes
Mar 31, 2026
Contributor
Luke-Bilhorn
left a comment
Luke-Bilhorn
left a comment
There was a problem hiding this comment.
Looks good works good
Luke-Bilhorn
deleted the
778-if-a-vtt-or-srt-file-is-not-valid-in-some-way-we-should-give-a-warning-during-import
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a warning for user when importing corrupted vtt / srt files with not sequential time stamps which result and corrupted outcomes.