Skip to content

Fix Patch Rebuild skipping .deb/.rpm/.AppImage builds #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JonahBraun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Patch Rebuild skipping .deb/.rpm/.AppImage builds #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/stable-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ jobs:
RELEASE_VERSION: ${{ env.RELEASE_VERSION }}
SHOULD_BUILD: ${{ env.SHOULD_BUILD }}
SHOULD_DEPLOY: ${{ env.SHOULD_DEPLOY }}
PATCH_REBUILD: ${{ env.PATCH_REBUILD }}
CUSTOM_RELEASE_VERSION: ${{ env.CUSTOM_RELEASE_VERSION }}

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -189,6 +191,8 @@ jobs:
RELEASE_VERSION: ${{ needs.check.outputs.RELEASE_VERSION }}
SHOULD_BUILD: ${{ (needs.check.outputs.SHOULD_BUILD == 'yes' || github.event.inputs.generate_assets == 'true') && 'yes' || 'no' }}
SHOULD_DEPLOY: ${{ needs.check.outputs.SHOULD_DEPLOY }}
PATCH_REBUILD: ${{ needs.check.outputs.PATCH_REBUILD }}
CUSTOM_RELEASE_VERSION: ${{ needs.check.outputs.CUSTOM_RELEASE_VERSION }}
VSCODE_ARCH: ${{ matrix.vscode_arch }}
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
outputs:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/stable-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ jobs:
RELEASE_VERSION: ${{ env.RELEASE_VERSION }}
SHOULD_BUILD: ${{ env.SHOULD_BUILD }}
SHOULD_DEPLOY: ${{ env.SHOULD_DEPLOY }}
PATCH_REBUILD: ${{ env.PATCH_REBUILD }}
CUSTOM_RELEASE_VERSION: ${{ env.CUSTOM_RELEASE_VERSION }}

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -164,6 +166,8 @@ jobs:
RELEASE_VERSION: ${{ needs.check.outputs.RELEASE_VERSION }}
SHOULD_BUILD: ${{ (needs.check.outputs.SHOULD_BUILD == 'yes' || github.event.inputs.generate_assets == 'true') && 'yes' || 'no' }}
SHOULD_DEPLOY: ${{ needs.check.outputs.SHOULD_DEPLOY }}
PATCH_REBUILD: ${{ needs.check.outputs.PATCH_REBUILD }}
CUSTOM_RELEASE_VERSION: ${{ needs.check.outputs.CUSTOM_RELEASE_VERSION }}
VSCODE_ARCH: ${{ matrix.vscode_arch }}
outputs:
RELEASE_VERSION: ${{ env.RELEASE_VERSION }}
Expand Down
14 changes: 7 additions & 7 deletions check_tags.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,14 +258,14 @@ elif [[ "${ASSETS}" != "null" ]]; then

# linux-arm64
if [[ "${VSCODE_ARCH}" == "arm64" || "${CHECK_ALL}" == "yes" ]]; then
if [[ -z $( contains "arm64.deb" ) ]]; then
if [[ -z $( contains "${RELEASE_VERSION}_arm64.deb" ) ]]; then
echo "Building on Linux arm64 because we have no DEB"
export SHOULD_BUILD="yes"
else
export SHOULD_BUILD_DEB="no"
fi

if [[ -z $( contains "aarch64.rpm" ) ]]; then
if [[ -z $( contains "${RELEASE_VERSION}-el8.aarch64.rpm" ) ]]; then
echo "Building on Linux arm64 because we have no RPM"
export SHOULD_BUILD="yes"
else
Expand Down Expand Up @@ -317,14 +317,14 @@ elif [[ "${ASSETS}" != "null" ]]; then

# linux-armhf
if [[ "${VSCODE_ARCH}" == "armhf" || "${CHECK_ALL}" == "yes" ]]; then
if [[ -z $( contains "armhf.deb" ) ]]; then
if [[ -z $( contains "${RELEASE_VERSION}_armhf.deb" ) ]]; then
echo "Building on Linux arm because we have no DEB"
export SHOULD_BUILD="yes"
else
export SHOULD_BUILD_DEB="no"
fi

if [[ -z $( contains "armv7hl.rpm" ) ]]; then
if [[ -z $( contains "${RELEASE_VERSION}-el8.armv7hl.rpm" ) ]]; then
echo "Building on Linux arm because we have no RPM"
export SHOULD_BUILD="yes"
else
Expand Down Expand Up @@ -500,14 +500,14 @@ elif [[ "${ASSETS}" != "null" ]]; then

# linux-x64
if [[ "${VSCODE_ARCH}" == "x64" || "${CHECK_ALL}" == "yes" ]]; then
if [[ -z $( contains "amd64.deb" ) ]]; then
if [[ -z $( contains "${RELEASE_VERSION}_amd64.deb" ) ]]; then
echo "Building on Linux x64 because we have no DEB"
export SHOULD_BUILD="yes"
else
export SHOULD_BUILD_DEB="no"
fi

if [[ -z $( contains "x86_64.rpm" ) ]]; then
if [[ -z $( contains "${RELEASE_VERSION}-el8.x86_64.rpm" ) ]]; then
echo "Building on Linux x64 because we have no RPM"
export SHOULD_BUILD="yes"
else
Expand All @@ -523,7 +523,7 @@ elif [[ "${ASSETS}" != "null" ]]; then

if [[ "${DISABLE_APPIMAGE}" == "yes" ]]; then
export SHOULD_BUILD_APPIMAGE="no"
elif [[ -z $( contains "x86_64.AppImage" ) ]]; then
elif [[ -z $( contains "${RELEASE_VERSION}.glibc" ) ]]; then
echo "Building on Linux x64 because we have no AppImage"
export SHOULD_BUILD="yes"
else
Expand Down
Loading