Add the option to timeout per host and not per ip #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Cherry pick to beta success |
Collaborator
Cherry pick to beta success |
iroqueta
previously approved these changes
Jun 23, 2025
Collaborator
iroqueta
reviewed
Jul 10, 2025
| connManager = new PoolingHttpClientConnectionManager(socketFactoryRegistry, dnsResolver); | ||
| } else { | ||
| connManager = new PoolingHttpClientConnectionManager(socketFactoryRegistry); | ||
| } |
Collaborator
There was a problem hiding this comment.
Maybe it better to use
boolean useCustomDnsResolver = getGxIpResolverConfig() != null;
PoolingHttpClientConnectionManager connManager = useCustomDnsResolver
? new PoolingHttpClientConnectionManager(socketFactoryRegistry, new FirstIpDnsResolver())
: new PoolingHttpClientConnectionManager(socketFactoryRegistry);
iroqueta
reviewed
Jul 10, 2025
Collaborator
iroqueta
left a comment
iroqueta
left a comment
There was a problem hiding this comment.
I suggest a minor change
Collaborator
Cherry pick to beta success |
iroqueta
approved these changes
Jul 11, 2025
tomas-sexenian
added a commit
that referenced
this pull request
Aug 6, 2025
This reverts commit b977075.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.