Skip to content

Implement getHyperlink and setHyperLink to xssf.ExcelCells #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 15, 2025
Merged

Implement getHyperlink and setHyperLink to xssf.ExcelCells #989

merged 5 commits into from
Jul 15, 2025

Conversation

@tomas-sexenian
Copy link
Contributor

@tomas-sexenian tomas-sexenian commented Jul 14, 2025 •
edited
Loading

Issue: 204861

@genexusbot
Copy link
Collaborator

genexusbot commented Jul 14, 2025

Cherry pick to beta success

iroqueta
iroqueta reviewed Jul 14, 2025
View reviewed changes
Copy link
Collaborator

@iroqueta iroqueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it necessary to implement the methods in the IExcelCells interface and provide the implementation in all the classes that implement the interface?

@genexusbot
Copy link
Collaborator

genexusbot commented Jul 14, 2025

Cherry pick to beta success

@tomas-sexenian
Copy link
Contributor Author

tomas-sexenian commented Jul 14, 2025

Isn't it necessary to implement the methods in the IExcelCells interface and provide the implementation in all the classes that implement the interface?

Maybe @claudiamurialdo knows best. How did .NET implemented this?

@genexusbot
Copy link
Collaborator

genexusbot commented Jul 14, 2025

Cherry pick to beta success

@claudiamurialdo
Copy link
Collaborator

claudiamurialdo commented Jul 14, 2025

Isn't it necessary to implement the methods in the IExcelCells interface and provide the implementation in all the classes that implement the interface?

Maybe @claudiamurialdo knows best. How did .NET implemented this?

This is not required for the GeneXusOffice external object.

@genexusbot
Copy link
Collaborator

genexusbot commented Jul 14, 2025

Cherry pick to beta success

@tomas-sexenian tomas-sexenian merged commit 82ba01e into master Jul 15, 2025
10 checks passed
@tomas-sexenian tomas-sexenian deleted the cells-link branch July 15, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iroqueta iroqueta iroqueta approved these changes

@claudiamurialdo claudiamurialdo claudiamurialdo left review comments

Assignees

No one assigned

Labels

bot closed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tomas-sexenian @genexusbot @claudiamurialdo @iroqueta