Open
Conversation
62bf54d to
1fb2883
Compare
1fb2883 to
abc0340
Compare
ce64044 to
9d18bcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
Core Telemetry Fixes (
js/core)enableTelemetryintracing.tsto correctly store and await the actual initialization promise. This prevents spans from being created before the SDK is fully ready.await flushTracing()tobeforeEachand relevant test cases inaction_test.tsandflow_test.ts. This ensures all asynchronously emitted spans are captured before assertions are made.MultiSpanProcessorinnode-telemetry-provider.tsto reliably handle multiple span processors across different OpenTelemetry versions.enableTelemetrylogic to properly shut down existing SDK instances before re-initializing, avoiding duplicate instrumentation and resource leaks.OpenTelemetry 2.0 Compatibility (
js/plugins/google-cloud)traces_test.tsto useparentSpanContext?.spanIdinstead of the deprecatedparentSpanIdproperty, which was removed in OTel 2.0.metrics_test.tsto use theInstrumentTypeenum for metric type comparisons.typeproperty from theMetricDescriptorinterface.Checklist (if applicable):
AIM
Dev UI