feat(js/plugins/google-genai): Support for lyria 3 in vertexAI#5028
Open
feat(js/plugins/google-genai): Support for lyria 3 in vertexAI#5028
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for new Gemini and Lyria model features, including response modalities, thinking configurations, and the Vertex AI interactions endpoint. Key updates include automated defaulting of response modalities for TTS and image models, enhanced error detail parsing in both Google AI and Vertex AI clients, and the addition of Lyria 3 model support. The review feedback focuses on improving error handling consistency by using GenkitError with specific statuses, refining imports, and removing unnecessary array copies. Additionally, it is recommended to align error message formatting across different client implementations to ensure a uniform user experience.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also some quality of life improvements (that kind of snowballed, sorry):
Checklist (if applicable):