Skip to content

feat(js/plugins/google-genai): Support for lyria 3 in vertexAI#5028

Open
ifielker wants to merge 2 commits intomainfrom
if-lyria3Vertex
Open

feat(js/plugins/google-genai): Support for lyria 3 in vertexAI#5028
ifielker wants to merge 2 commits intomainfrom
if-lyria3Vertex

Conversation

@ifielker
Copy link
Copy Markdown
Collaborator

Also some quality of life improvements (that kind of snowballed, sorry):

  • response modalities for image models and audio models now have defaults
  • error message details are now included in the error. (and formatted nicely)
  • nano banana 2 image sizes are updated

Checklist (if applicable):

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for new Gemini and Lyria model features, including response modalities, thinking configurations, and the Vertex AI interactions endpoint. Key updates include automated defaulting of response modalities for TTS and image models, enhanced error detail parsing in both Google AI and Vertex AI clients, and the addition of Lyria 3 model support. The review feedback focuses on improving error handling consistency by using GenkitError with specific statuses, refining imports, and removing unnecessary array copies. Additionally, it is recommended to align error message formatting across different client implementations to ensure a uniform user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant