fix(py): Fix pyproject.toml on fastapi plugin#5030
Open
huangjeff5 wants to merge 3 commits intomainfrom
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the build configuration for the FastAPI plugin in pyproject.toml, specifically changing how files are included in the wheel distribution. A critical issue was identified where switching from packages to only-include would result in an incorrect file structure within the built wheel, breaking standard imports. The feedback suggests reverting to the packages configuration to maintain the correct namespace mapping.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug preventing the genkit-plugin-fastapi package from being uploaded to PyPI (returning a 400 Bad Request: Duplicate filename in local headers error), and standardizes the Hatchling wheel build configurations across all Python plugins to guarantee safe editable installs during testing.