Switched mesh-ui search sort from creation date to relevancy score#332
Open
fmteixeira wants to merge 1 commit intogentics:developfrom
Open
Switched mesh-ui search sort from creation date to relevancy score#332fmteixeira wants to merge 1 commit intogentics:developfrom
fmteixeira wants to merge 1 commit intogentics:developfrom
Conversation
Contributor
|
Thanks for the PR. We have unfortunately no resources to review the PR at the moment. I'll let you know when / if this changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #331
When searching in the mesh-ui, the results are ordered by the creation date instead of the relevancy score, this creates the following problems:
Image of a search where the most relevant is not at the top
It seems that this is affected by the code on the images below, I suggest removing the "sort" parameters from these queries as it will use the relevancy by default.
Code 1 at "src\app\core\providers\effects\list-effects.service.ts" line 189
Code 2 at "src\app\core\providers\effects\list-effects.service.ts" line 232