ebuild-writing/variables: add QA control variables section#386
ebuild-writing/variables: add QA control variables section#386ingenarel wants to merge 2 commits intogentoo:masterfrom
Conversation
Signed-off-by: ingenarel (NeoJesus) <ingenarel_neojesus@disroot.org>
7fbc219 to
5ecb26c
Compare
|
ok i recommitted with the proper --signoff, fixed word wrapping to 80 chars as per the coding style, and added the necessary changes, if anything else is needed please lemme know |
5ecb26c to
9b195cb
Compare
|
okay i have also properly did the and also did
please lemme know if anything else is needed |
ebuild-writing/variables/text.xml
Outdated
| <tr> | ||
| <ti><c>QA_AM_MAINTAINER_MODE</c></ti> | ||
| <ti> | ||
| This should contain a list of lines containing automake missing |
There was a problem hiding this comment.
Can we please reword to avoid contain/containing in the same sentence?
9b195cb to
fe8336f
Compare
thesamesam
left a comment
There was a problem hiding this comment.
Looks okay to me. I'd like to avoid these "This should contain..." but it's not something I insist on you fixing.
ebuild-writing/variables/text.xml
Outdated
| <tr> | ||
| <ti><c>QA_AM_MAINTAINER_MODE</c></ti> | ||
| <ti> | ||
| This should be a list of lines containing automake missing <c>--run</c> |
There was a problem hiding this comment.
Just make all of these "A list of ...". No need for "This should be" or "This should contain", it doesn't transport any additional information.
Signed-off-by: ingenarel (NeoJesus) <ingenarel_neojesus@disroot.org>
fe8336f to
2e93cb3
Compare
|
Thanks, merged. |
these variables and their docs can be found if you do
man 5 ebuild,however they're not in the devmanual itself
this pr should fix that
originally found it out because i was working on this: mfussenegger/nvim-lint#904