PB-1522 : fix confederation text shrinking/covered in print view #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
fix-PB-1522-print-conf-logo-text-width
|
| Run status |
|
| Run duration | 06m 00s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
250
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
tests/cypress/tests-e2e/importToolMaps.cy.js • 1 failed test • e2e/chrome/mobile
| Test | Artifacts | |
|---|---|---|
| The Import Maps Tool > Import external WMTS layers |
Test Replay
Screenshots
|
|
pakb
force-pushed
the
fix-PB-1522-print-conf-logo-text-width
branch
2 times, most recently
from
75f32dd to
d5a9ddb
Compare
pakb
force-pushed
the
fix-PB-1522-print-conf-logo-text-width
branch
2 times, most recently
from
74e13df to
8acb40c
Compare
When using a narrow layout (such as A4 portrait) the confederation text was switching to the "mobile" layout, and using a width that match only the flag.
pakb
force-pushed
the
fix-PB-1522-print-conf-logo-text-width
branch
from
8acb40c to
86181fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a narrow layout (such as A4 portrait) the confederation text was switching to the "mobile" layout, and using a width that match only the flag.
Test link