Feature/chat result pub #7
Open
+1,002
−837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* assets/image 추가 * expo-linear-gradient 라이브러리 추가
peanudge
reviewed
Nov 17, 2021
peanudge
reviewed
Nov 17, 2021
Contributor
peanudge
left a comment
peanudge
left a comment
There was a problem hiding this comment.
고생하셨어요! 리뷰한번만 체크해주세요! 갠적으로 스타일은 하나의 방식으로 통합하는게 좋아보이네요
| "jest.config.js" | ||
| ] | ||
| ], | ||
| "extends": "expo/tsconfig.base" |
| height: 60, | ||
| borderRadius: 33.5 | ||
| } | ||
| }) |
Contributor
There was a problem hiding this comment.
stylesheet이랑 styled-component방식을 혼합해서 쓰셨는데 styled component로 처리하는게 좋지않을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 PR은 #6 위에서 진행되었습니다.
대화 종료 페이지(ChatResult) 퍼블리싱
resolve #3