Convert percent to fraction in Geodynamic WorldBuilder#6477
Merged
bangerth merged 1 commit intogeodynamics:mainfrom Jun 17, 2025
Merged
Convert percent to fraction in Geodynamic WorldBuilder#6477bangerth merged 1 commit intogeodynamics:mainfrom
bangerth merged 1 commit intogeodynamics:mainfrom
Conversation
Contributor
|
Backporting fixes seems reasonable. Another option would be to import a newer version of WorldBuilder. (If there is one.) |
MFraters
approved these changes
Jun 17, 2025
Member
MFraters
left a comment
MFraters
left a comment
There was a problem hiding this comment.
There is currently no release with that fix, so a backport seems reasonable to me in this case.
Member
|
/rebuild |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a fix that I had made in the main branch of the world builder here, but it is not in the current version of worldbuilder that comes bundled with ASPECT. The world builder currently outputs the percent bound fluid using the tian 2019 composition model, but this means that in the ASPECT model, which expects mass fractions, the bound water would have a value of say 50, instead of 0.5. This PR fixes this issue.
I need this for a cookbook I'm working on in PR #6455, so I implemented the fix exactly as is done in the current main branch of the world builder. @MFraters I think we've done something like this before but just in case maybe you can take a look