Split radial gravity plugins into separate files#6681
Split radial gravity plugins into separate files#6681bangerth merged 3 commits intogeodynamics:mainfrom
Conversation
|
Hi Rene! Was going through #6614 with Hyunseong which led us to this PR and I noticed that this code includes the radial_earth_like plugin. This seems to have been deprecated in the old code and I was wondering if it makes sense to include it here? |
|
Uhm, I am not sure what you mean by |
|
As far as I remember, our intention (@Geoniette and I) was to let you know that there is deprecated class, so you can just remove it without separating it. |
|
Hi both! Yep I was just flagging that the radial earth-like plugin was deprecated in the older version but was still included as a plugin in this PR. |
1a8a54f to
fe7ae8f
Compare
|
Ok, thanks for pointing that out! Actually after your comment I decided to just delete the radial earth-like plugin. I checked and shockingly I disabled that plugin 8 years ago, so it is definitely time for it to go. This PR should be ready for a review. |
While reviewing #6614 I saw that we pack three gravity plugins into one file. This is not completely unreasonable as they are all quite small. However, I think in line with keeping all plugin files as similar as possible to each other it would be more intuitive to pack one plugin per file as we do almost everywhere else. I split the classes into separate files and deprecated the old header file (it still includes the three new files, so existing code continues to work).
Let me know if the deprecation message using the
#pragma messageapproach is the best way to notify users.