Open
Conversation
bangerth
approved these changes
Oct 31, 2025
source/simulator/parameters.cc
Outdated
| "requires there to be a compositional field named porosity that is advected " | ||
| "the darcy field method. We calculate the fluid velocity $u_f$ using an " | ||
| "approximation of Darcy's Law: $u_f = u_s - K_D / \\phi * (rho_s * g - rho_f * g)$." | ||
| "with the darcy field method. We calculate the fluid velocity $u_f$ using an " |
Contributor
There was a problem hiding this comment.
We should also replace darcy -> Darcy. Perhaps for your next workshop :-)
Contributor
Author
There was a problem hiding this comment.
I couldn't wait :-)
anne-glerum
force-pushed
the
fix_typos_0325
branch
from
79ceedf to
837d908
Compare
Contributor
|
Do you want to merge this PR, or are you still waiting for other PRs to get merged first? |
Contributor
|
@anne-glerum ping? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the typos I identified for the workshop yesterday. Some of them have been fixed by the others, so let's wait till those PRs are merged.