Fix input_t.prm in the nonlinear channel flow benchmark#6851
Merged
alarshi merged 1 commit intogeodynamics:mainfrom Feb 10, 2026
Merged
Fix input_t.prm in the nonlinear channel flow benchmark#6851alarshi merged 1 commit intogeodynamics:mainfrom
alarshi merged 1 commit intogeodynamics:mainfrom
Conversation
alarshi
reviewed
Feb 7, 2026
Contributor
alarshi
left a comment
alarshi
left a comment
There was a problem hiding this comment.
Thank you for noticing this bug and fixing it!
What you did is correct but I was wondering if we can achieve the same changes by just copying the Solver parameters subsection (ln 19- ln 35) and including the input_v.prm file as before, since everything else is not changed by the run.sh script.
Besides one small change in the comment, it looks good to me if the tester is happy.
| # Like input_v.prm and based on the nonlinear channel | ||
| # flow benchmark. This is used to test the traction boundary conditions | ||
| # Like the input_v.prm test and based on the nonlinear channel | ||
| # flow benchmark. This is used to test the velocity boundary conditions |
Contributor
There was a problem hiding this comment.
I think you accidentally changed it. Please change it back to traction.
Contributor
|
/rebuild |
MFraters
reviewed
Feb 9, 2026
| set Variable names = x,y | ||
|
|
||
| # For velocity boundary conditions both are used, for pressure boundary conditions only the first (x) component | ||
| set Function expression = 0;(1e-37/(n+1))*((1e9/8e3)^n)*(((5e3)^(n+1))-(abs(x-(5e3))^(n+1))); |
Member
There was a problem hiding this comment.
I think the second part can be zero as well now as it is no y component. It should not matter, but I think it looks more clean than a complicated function.
YiminJin
force-pushed
the
input_t_prm
branch
from
1d34af3 to
85a6623
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of the latest issue displayed in #6471 . The template input file
input_t.prminbenchmarks/newton_solver_benchmark_set/nonlinear_channel_flowusesinclude input_v.prmfor simplicity, but it makes the bash scriptrun.shproduce the same result for different cases, because commands like-e "s/set Output directory .*/set Output directory = results\/$dirname_clean/g"does not work. This PR replacesinclude input_v.prmby the actual parameter settings, and the problem is mended. The results with traction boundary conditions are show below: