Default to updating stack without checking pull requests #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geofflamrock
force-pushed
the
update-using-local-only
branch
from
33b4e4e to
0e58bf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we always check the status of GitHub pull requests when updating a stack (during the
updateorsynccommand), this slows down the entire operation quite considerably. The default workflow that I use is to delete the remote tracking branch when a PR merges anyway so this is unnecessary.This PR changes updating a stack to not check GitHub pull requests by default. A new option
--check-pull-requestshas been added to both theupdateandsynccommands to support this if needed. I've also renamed the--fulloption to--check-pull-requeststo match in thestatuscommand.It also no longer checks the status of branches compared to each other as this isn't needed and only slows things down.