Support divergent color ramps #912

nakul-py · 2025-08-29T14:37:31Z

Description

Addresses #881

Currently, Color Ramp Type only supports Divergent colors such as balance, delta , curl, diff and tarn so other colormaps are still show type unknown. Enable users to set a minimum and maximum value for the colormap.

Checklist

PR has a descriptive title and content.
PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
PR has one of the labels: documentation, bug, enhancement, feature, maintenance
Checks are passing.
Failing lint checks can be resolved with:
- pre-commit run --all-files
- jlpm run lint

📚 Documentation preview: https://jupytergis--912.org.readthedocs.build/en/912/
💡 JupyterLite preview: https://jupytergis--912.org.readthedocs.build/en/912/lite

github-actions · 2025-08-29T14:37:40Z

👈 Launch a Binder on branch nakul-py/jupytergis/divergent

github-actions · 2025-08-29T14:49:11Z

Integration tests report: appsharing.space

nakul-py

cmocean's "balance" is cool :)

packages/base/src/dialogs/symbology/colorRampUtils.ts

mfisher87

Hey Nakul! This looks really good so far! I have some thoughts on the implementation details, most importantly around saving the min & max into the project file as symbologyState.min, symbologyState.max and updating singleband pseudocolor (for raster data) to share the same behavior. We can definitely share a common component!

packages/base/src/dialogs/symbology/colorRampUtils.ts

packages/base/src/dialogs/symbology/components/color_ramp/ColorRamp.tsx

packages/base/src/dialogs/symbology/vector_layer/types/Categorized.tsx

packages/base/src/dialogs/symbology/symbologyUtils.ts

packages/base/src/dialogs/symbology/components/color_ramp/ColorRamp.tsx

packages/base/src/panelview/components/legendItem.tsx

mfisher87 · 2025-09-10T16:43:47Z

Hey @nakul-py I'm a bit overwhelmed with interviewing folks for an internship program. I may be a bit delayed!

Co-authored-by: Nakul Verma <nakulverma.py@gmail.com>

mfisher87

Nakul and I worked on this together for a little bit today. Just leaving some thoughts we talked about -- I'll get to a more comprehensive review on Monday!

packages/base/src/dialogs/symbology/colorRampUtils.ts

mfisher87 · 2025-09-12T15:46:47Z

packages/base/src/dialogs/symbology/components/color_ramp/ColorRamp.tsx

  const [selectedMode, setSelectedMode] = useState('');
  const [numberOfShades, setNumberOfShades] = useState('');


Not for this PR: These should be typed better! numberOfShades should be number and selectedMode should be a union of string literals.

Co-authored-by: Yao-Ting Yao <94820616+YaoTingYao@users.noreply.github.com> Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>

* Only display when in equal interval mode -- harder to calculate critical value in other modes * Dynamically calculate critical value instead of displaying 50% * Move under color ramp selector Co-authored-by: Yao-Ting Yao <94820616+YaoTingYao@users.noreply.github.com> Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>

Co-authored-by: Yao-Ting Yao <94820616+YaoTingYao@users.noreply.github.com> Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>

Reverse is successfully being loaded from the shared model, but not min/max :( Co-authored-by: Yao-Ting Yao <94820616+YaoTingYao@users.noreply.github.com> Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>

…ngleBandPseudoColor components

Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>

mfisher87 · 2025-10-03T15:30:44Z

Thoughts on saving band-level min/max values: Should we use the state DB? Or should we use the shared document? (@martinRenou @arjxn-py @gjmooney would love your thoughts)

I'm leaning towards the shared document. This would require some changes to the shared document schema. See Issue #946.

This should not be part of this PR. It's mostly a performance concern. If the user clicks "Use actual range" and it looks at the data to find the min/max for the selected band at that time, it'd be a touch slower. But I think that's fine.

For this PR: Remove the use of the global state DB and look at the data to find the dataMin/dataMax values for the "use actual range button". We'll make it faster later!

We should also remove the min/max fields on the geotiff new layer dialog so we don't ask the user to input min/max in two places! Currently in this PR, for singleband pseudocolor, the min/max in the source parameters affects rendering. E.g. setting the source minimum to 2000 in the geotiff example file doesn't work the same as setting the symbology minimum to 2000. This can be seen in which pixels are transparent. Related #946

Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>

mfisher87 · 2025-10-03T15:46:43Z

The symbology "OK" button sometimes doesn't work when manually changing the min and max. Changing the min and max again can re-enable the "OK" button. I'm not sure what the pattern is yet :)

It was failing because symbologyState was not populated in the shared document at this point. Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>

mfisher87 · 2025-10-03T15:53:40Z

For singleband pseudocolor, the classification stops don't load on the 2nd, 3rd, etc. opens of the symbology menu. This is a pre-existing bug. Ignore this comment :) #947

mfisher87 · 2025-10-03T17:25:48Z

packages/base/src/mainview/mainView.tsx

              return {
                ...addNoData(sourceInfo),
-                min: sourceInfo.min,
-                max: sourceInfo.max,


I think this may be the difference in the rendering. We probably need to hook up the user's selected min/max values here. Testing...

Yes! This fixes the problem: 5eb2a4c

Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>

mfisher87 · 2025-10-03T19:22:56Z

cf7fe08 removes the min/max source input fields. But now the rendering is non-deterministic. Try clicking classify, then OK, then re-open symbology, re-classify, and click OK. The rendered data can look different each time.

This data should come from symbology choices.

mfisher87 · 2025-10-03T23:41:39Z

443d195 resolves the initialization of the OpenLayers Source object's min/max values from the symbology info. This is follow-on work resolving problems introduced in cf7fe08. We still need to initialize the symbology info from the file at initialization time (here, if symbologyState isn't defined, look at the data to find the min and max and save it into symbology state: https://github.com/nakul-py/jupytergis/blob/443d19524930b610859583a03f6d3f2f93d5b68a/packages/base/src/mainview/mainView.tsx#L798-L799)

nakul-py · 2025-10-04T05:57:25Z

4755f5e this commit fixes that we always get 0/100 fallback values as min/max. Now we got min/max from actual data.

Supporting divergent colomaps

78e9966

nakul-py added 2 commits August 29, 2025 20:48

critical value only for divergent

63bcb15

Divergent with min-max

e9ecb40

nakul-py changed the title ~~Wip: Supporting divergent colomaps with critical value~~ Supporting divergent colomaps with critical value Sep 2, 2025

nakul-py marked this pull request as ready for review September 2, 2025 12:16

nakul-py commented Sep 2, 2025

View reviewed changes

packages/base/src/dialogs/symbology/colorRampUtils.ts Outdated Show resolved Hide resolved

mfisher87 added the enhancement New feature or request label Sep 3, 2025

mfisher87 requested changes Sep 3, 2025

View reviewed changes

mfisher87 changed the title ~~Supporting divergent colomaps with critical value~~ Support divergent color ramps Sep 3, 2025

mfisher87 reviewed Sep 3, 2025

View reviewed changes

packages/base/src/panelview/components/legendItem.tsx Outdated Show resolved Hide resolved

mfisher87 requested a review from arjxn-py September 3, 2025 16:13

nakul-py marked this pull request as draft September 5, 2025 08:53

nakul-py added 5 commits September 5, 2025 14:31

changes

2e2f37b

lint fix

67faef4

support singleband psuedocolor

1af0c01

pre-populating values

19ed962

making radius work wit min and max

dbeb780

nakul-py marked this pull request as ready for review September 9, 2025 11:02

nakul-py requested a review from mfisher87 September 9, 2025 11:02

gives colors a sequance

c1fbede

Simplify call to useColorMapList effect

b478a85

Co-authored-by: Nakul Verma <nakulverma.py@gmail.com>

mfisher87 force-pushed the divergent branch from 3a488a0 to b478a85 Compare September 12, 2025 15:32

Remove type assertion

df7df8f

Co-authored-by: Nakul Verma <nakulverma.py@gmail.com>

mfisher87 reviewed Sep 12, 2025

View reviewed changes

geojupyter-pr-triage bot added this to JupyterGIS PR triage Sep 12, 2025

nakul-py force-pushed the divergent branch from 835794a to c067f57 Compare September 14, 2025 08:37

Update selectedRamp state initialization

4c86aaf

refactoring

25183fc

nakul-py force-pushed the divergent branch from 9e3698b to 25183fc Compare October 1, 2025 09:42

nakul-py and others added 13 commits October 1, 2025 19:25

Add reverse option to color ramp rendering

504a687

Use disabled property to style input fields

2b5223b

Improve label of "use actual range" button

928278a

Co-authored-by: Yao-Ting Yao <94820616+YaoTingYao@users.noreply.github.com> Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>

Improve conditions to disable min/max controls

345af02

Co-authored-by: Yao-Ting Yao <94820616+YaoTingYao@users.noreply.github.com> Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>

Skip rendering the minmax controls if rendertype incorrect

cc0901f

Co-authored-by: Yao-Ting Yao <94820616+YaoTingYao@users.noreply.github.com> Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>

Leave props packed in "props" object

18abc0e

Co-authored-by: Yao-Ting Yao <94820616+YaoTingYao@users.noreply.github.com> Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>

Save "reverse", "min", and "max" into symbology state in shared model

6ec6d16

Co-authored-by: Yao-Ting Yao <94820616+YaoTingYao@users.noreply.github.com> Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>

min and max succesfully loading from shared model or lint fix

273b7f5

Refactor warning in ColorRampValueControls and min/max handling in Si…

ec77af3

…ngleBandPseudoColor components

Load cached min/max values for selected band in SingleBandPseudoColor

9f56575

Use implicit undefined state default

b433b1d

Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>

Remove obsolete comment

c67144a

Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>

Fix symbology screen crashing when opening for a new layer

5de88cc

It was failing because symbologyState was not populated in the shared document at this point. Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>

mfisher87 reviewed Oct 3, 2025

View reviewed changes

mfisher87 and others added 2 commits October 3, 2025 11:50

Get the min/max geotiff values from symbology state

5eb2a4c

Co-authored-by: Nakul Verma <173621577+nakul-py@users.noreply.github.com>

Remove min/max source fields

cf7fe08

mfisher87 added 3 commits October 3, 2025 14:01

Don't initialize min/max from user input when adding layer

3033b51

This data should come from symbology choices.

Remove console.logs

d1c7ce9

Set the OpenLayers Source object with min/max from symbology info

443d195

fix min/max values fallback

4755f5e

		const [selectedMode, setSelectedMode] = useState('');
		const [numberOfShades, setNumberOfShades] = useState('');

Support divergent color ramps #912

Are you sure you want to change the base?

Support divergent color ramps #912

Uh oh!

Conversation

nakul-py commented Aug 29, 2025 • edited by mfisher87 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

github-actions bot commented Aug 29, 2025

Uh oh!

github-actions bot commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nakul-py left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mfisher87 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mfisher87 commented Sep 10, 2025

Uh oh!

mfisher87 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mfisher87 Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

mfisher87 commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mfisher87 commented Oct 3, 2025

Uh oh!

mfisher87 commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mfisher87 Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

mfisher87 Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

mfisher87 commented Oct 3, 2025

Uh oh!

mfisher87 commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nakul-py commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nakul-py commented Aug 29, 2025 •

edited by mfisher87

Loading

github-actions bot commented Aug 29, 2025 •

edited

Loading

nakul-py left a comment •

edited

Loading

mfisher87 left a comment •

edited

Loading

mfisher87 commented Oct 3, 2025 •

edited

Loading

mfisher87 commented Oct 3, 2025 •

edited

Loading

mfisher87 commented Oct 3, 2025 •

edited

Loading

nakul-py commented Oct 4, 2025 •

edited

Loading