Skip to content

Conversation

@cmangeat
Copy link
Contributor

@cmangeat cmangeat commented Nov 27, 2025

When using dbcp as a connection pool, with a validation query is used to probe connections, it happens that probed connections cannot be set read-only anymore. With hikari, it is possible given that 'isolateInternalQueries' hikari configuration is set to true.

(with dbcp, 'cannot set connection read-only...' messages can be seen given that log4j-dev conf. is used)

cannot_change_transaction_read-only-property_in_the_middle_of_a_transaction

Please also note that 7e4ec9d#diff-5035522e09ba653fd7fd93d85c31ee0cf090b4c731eeb3e7cb3c042f837e2db3R49 fix log4j-dev parsing and can make "mvn jetty:run" very verbose.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

…o avoid 'cannot change transaction read-only property'
@cmangeat cmangeat force-pushed the hikari_cp_connection_pool_for_postgres_postgis branch from 66bca05 to 7e4ec9d Compare November 27, 2025 14:57
@cmangeat cmangeat changed the title a postgres-postgis config file with an hikari cp connection pool... New postgres-postgis config file with an hikari cp connection pool. Nov 27, 2025
@cmangeat cmangeat marked this pull request as ready for review November 27, 2025 15:36
@sebr72
Copy link
Contributor

sebr72 commented Nov 27, 2025

@PascalLike Could you please rerun the failjng Check above as we do not have permission to do it. Cheers.

@juanluisrp
Copy link
Contributor

Relaunched.

Copy link
Contributor

@sebr72 sebr72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants