Iso19115-3.2018, full view, linkage multilingual support #9120
+15,022
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adresses three requirements:
Iso19115-3.2018 linkages are multilingual elements, when displaying them,
A sequence of more than one item is not allowed as the first argument of string() (<gco:CharacterString/>, <lan:PT_FreeText/>)error must be avoided.
Furthermore, based on ui's language, the correct url should be chosen.
At the end, many scenarios should be supported:
there is a name and an url in xml -> in html, name carry the url (href),
there is no name but a url -> in html, 'url text' carry the url,
there is a name but no url -> a text is displayed with no href.
Checklist
I have read the contribution guidelines
Pull request provided for
mainbranch, backports managed with labelGood housekeeping of code, cleaning up comments, tests, and documentation
Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
Clean commit messages, longer verbose messages are encouraged
API Changes are identified in commit messages
Testing provided for features or enhancements using automatic tests
User documentation provided for new features or enhancements in manual
Build documentation provided for development instructions in
README.mdfilesLibrary management using
pom.xmldependency management. Update build documentation with intended library use and library tutorials or documentationFunded by geocat.ch