[Datahub] FIX handle error (display msg) also for TMS#1259
Merged
Conversation
50c552d to
c8de0e8
Compare
Contributor
|
Affected libs: Affected apps:
|
Contributor
|
📷 Screenshots are here! |
7f84573 to
2022c71
Compare
tkohr
approved these changes
Jun 11, 2025
Collaborator
tkohr
left a comment
There was a problem hiding this comment.
Thanks @AlitaBernachot ! The error message displays on the map, the drop-down renders with the source title, and the API section does not stay empty.
The error message is rather generic, but this is also the case for other fetches by the data.service and getting more info here implies bigger changes in the geospatial-sdk and potentially even ol-mapbox-style if I recall correctly. So I agree to stick to your message for now.
9a7c4a3 to
1254533
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR displays an error message on the map when TMS endpoint fails.
It also forces the display of the source even if the enpoint fails to respond (dropdown was empty before the fix).
Another fix, display api links even if one TMS endpoint is in error:

Architectural changes
None (no update of the sdk needed)
Screenshots
Quality Assurance Checklist
breaking changelabelbackport <release branch>labelHow to test
Follow these instructions to confirm an error message is displayed on the map when the TMS endpoint fails to respond.
The dataset should have a (failing) TMS link:
https://data.geopf.fr/tms/to reproduce the error. (NB. the correct url ishttps://data.geopf.fr/tms/la_ciotat_gpkg_21-05-2025_tmsbut this is not what we want to test here)you can add this failing TMS via the XML editor:
or you can use this dataset: https://ign-gpf-test.apps.gs-ch-prod.camptocamp.com/geonetwork/srv/eng/catalog.search#/metadata/zzz_nl_test_wfs_syth_la_ciotat.
Go to the dataset's page (eg. http://localhost:4200/dataset/zzz_nl_test_wfs_syth_la_ciotat) and check the Map overview, it should display an error message.
Try to add other type of sources, it should display the other sources as before.