[Datahub]: Add interactive map filter to STAC viewer#1403
[Datahub]: Add interactive map filter to STAC viewer#1403AlexianMasson merged 55 commits intomainfrom
Conversation
|
Affected libs: Affected apps:
|
d6050de to
ee305e4
Compare
|
📷 Screenshots are here! |
bdb8b96 to
225c90c
Compare
225c90c to
07824e4
Compare
653e8ea to
adbab71
Compare
…lterCompoenent template
9c6a712 to
f51c9fb
Compare
f51c9fb to
d8ddf02
Compare
See the mat-tab doc: https://material.angular.dev/components/tabs/overview#lazy-loading Eagerly loading the content of the tab meant the OL map was created while detached from the page, which in turn meant no valid size for the map
… map state tracking
07fbc38 to
e5c7458
Compare
3dceacd to
65df609
Compare
…value when resetFilters called
… one BehaviourSubject + fixes + update tests
c3f85f9 to
984b5f8
Compare
|
📷 Screenshots for webcomponents are here! |
87f229c to
ccc9ac7
Compare
ccc9ac7 to
fae58db
Compare
There was a problem hiding this comment.
Thanks for huge work and the continued refactoring on this @AlexianMasson ! I really like your solution for the stac-view.component and it works very smoothly. The tests for it should still be cleaned from timeouts and comments I think.
Also just noticed that we don't have any e2e tests on the spatial filters, not sure if we have time to add one or two.
In the future it would make sense to have the _resolvedExtentChange in the geospatial-sdk I guess, but the implementation in the map-conatiner.component seems acceptable for now.
| (displayStac$ | async) && (selectedView$ | async) === 'stac' | ||
| " | ||
| > | ||
| <ng-template matTabContent> |
There was a problem hiding this comment.
Looking at the doc @jahow pointed to, it would make sense to put the contents of all four tabs in ng-templates (the other tabs only do so for the tab titles), I guess, but we can have a look at this in a separate PR.
There was a problem hiding this comment.
We can do an atomic PR to handle only those changes :)
libs/feature/record/src/lib/stac-view/stac-view.component.spec.ts
Outdated
Show resolved
Hide resolved
libs/feature/record/src/lib/stac-view/stac-view.component.spec.ts
Outdated
Show resolved
Hide resolved
fd33723 to
73ba74a
Compare
73ba74a to
2344fac
Compare
d0a1a74 to
6d0412d
Compare
…tTimeout (finalize)
tkohr
left a comment
There was a problem hiding this comment.
Thanks for the adaptions @AlexianMasson !
Thanks for the (looooong) review 😄 |
Description
This PR enhances the STAC (SpatioTemporal Asset Catalog) viewer with an interactive map and spatial filtering capabilities. Users can now filter STAC items by both temporal extent (via date pickers) and spatial extent (via map interaction).
Architectural Changes
Dependencies Updated:
@geospatial-sdk/*packages from0.0.5-dev.37to0.0.5-dev.40in both root and package directoriesComponent Modifications:
StacViewComponent- Added spatial filtering logicMapContainerComponent- Template refactor to have the map div as root and overlay component as ng-content + addedresolvedExtentChangeandextentChangeeventsCheckToggleComponent- Minor template improvements for better stylingRecordDataPreview.component- Fix STAC tab content with lazy loading.Screenshots
Desktop :

Mobile :

Quality Assurance Checklist
breaking changelabelbackport <release branch>labelHow to Test
http://localhost:4200/dataset/sentinel2-l2a-sen2corNotes
This work is sponsored by INRAE.