fix: improve security for SP's XHR proxy default configuration#489
Merged
fix: improve security for SP's XHR proxy default configuration#489
Conversation
Deny requests via the XHR proxy by default. Tests: The XHR proxy is already tested in several ways via the testsuite, see: https://github.com/georchestra/security-proxy/blob/main/src/test/java/org/georchestra/security/PermissionsTest.java But the new configuration suggested in the PR has been tested with the following test case: ``` @test public void testDefaultDatadirConfig() throws IOException { Permissions perm = this.load("test-permissions-default-datadir.xml"); assertTrue(perm.isDenied(new URL("http://www.google.fr/test.html"))); assertTrue(perm.isDenied(new URL("http://127.0.0.1:8080/console/private/internal/users.json"))); assertTrue(perm.isDenied(new URL("http://console-svc:8080/console/"))); assertTrue(perm.isDenied(new URL("https://sdi.georchestra.org/console/"))); assertTrue(perm.isDenied(new URL("https://demo.georchestra.org/geoserver/wms"))); } ``` e.g. with a mix of internal IP addresses, internal host names, and external resources.
landryb
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deny requests via the XHR proxy by default.
Tests:
The XHR proxy is already tested in several ways via the testsuite, see: https://github.com/georchestra/security-proxy/blob/main/src/test/java/org/georchestra/security/PermissionsTest.java
But the new configuration suggested in the PR has been tested with the following test case:
e.g. with a mix of internal IP addresses, internal host names, and external resources.