gateway - Add logging config#490
Conversation
| level: | ||
| root: info | ||
| org.springframework: info | ||
| org.georchestra.gateway: debug |
There was a problem hiding this comment.
Wouldn't that be an issue to log everything by default with debug details? Could also create a lot of logs on high traffic georchestra platforms.
And make the diagnostic more difficult due to the high amount of logs?
There was a problem hiding this comment.
afaik that's the default sample config file in the docs ?
There was a problem hiding this comment.
no it's the datadir used by the development docker compose: https://github.com/georchestra/georchestra-gateway/blob/9c2d8aef0717332aed8bbd5f4e43cc2a898b5901/docker-compose.yml#L42
the default config is there: https://github.com/georchestra/georchestra-gateway/blob/main/gateway/src/main/resources/application.yml
and it does not include all the debugs
There was a problem hiding this comment.
fwiw, i dont recognize that config layout, and furthermore, the original commit made by @Gaetanbrl was imo right, since (to my understanding of this yaml vomit) the debug levels were activated only on spring profiles logging_debug & logging_debug_security which ... makes sense.
| # included when using the json-logs profile. For the regular console output you could tweak the logback-spring.xml | ||
| # config file to include the required MDC properties | ||
| # In any case, the activated MDC will be visible when using the OpenTelemetry protocol | ||
| mdc: |
There was a problem hiding this comment.
Weren't the access logs already enabled here: georchestra/georchestra-gateway#146?
landryb
left a comment
landryb
left a comment
There was a problem hiding this comment.
i'm 👍 with this, i have more or less the same starting point, with some modifications from https://docs.georchestra.org/analytics/en/latest/technical_guides/installation/configuration/gateway/#enabling-enhanced-access-logs for georchestra/ansible#160
taken from https://docs.georchestra.org/analytics/en/latest/technical_guides/installation/configuration/gateway/#exposing-the-logs-over-opentelemetry-protocol gateway logging config will come on top of georchestra/datadir#490
taken unmodified from georchestra/datadir#490 while here stop deploying some configs we don't modify
3 participants
No issue, just an initial gateway/datadir sync arround logging.