Add pool parameter support to Emcee model (Fix #95)#113
Merged
georgebv merged 4 commits intogeorgebv:masterfrom Feb 19, 2026
Merged
Add pool parameter support to Emcee model (Fix #95)#113georgebv merged 4 commits intogeorgebv:masterfrom
georgebv merged 4 commits intogeorgebv:masterfrom
Conversation
Add support for the `pool` parameter in the `Emcee` model, allowing users to leverage parallel processing capabilities of `emcee.EnsembleSampler`. This enhancement enables faster chain computations, which is beneficial for large datasets or complex models. Changes: - `src/pyextremes/models/model_emcee.py`: Updated `Emcee` class to accept `pool` argument in `__init__` and pass it to `emcee.EnsembleSampler` in `fit`. - `src/pyextremes/models/models.py`: Updated `get_model` function signature and docstring. - `src/pyextremes/eva.py`: Updated `EVA.fit_model` method signature and docstring. - `tests/models/test_model_emcee.py`: Added a test case `test_fit_with_pool` to ensure `pool` is correctly passed to the sampler. - Formatted code with `ruff` and ensured PEP8 compliance.
jultou-raa
changed the title
jultou-raa
changed the title
jultou-raa
commented
Feb 16, 2026
Contributor
Author
There was a problem hiding this comment.
This fix is not related to the #95 fix, but is linked to a ruff tool check error
georgebv
requested changes
Feb 17, 2026
Owner
georgebv
left a comment
georgebv
left a comment
There was a problem hiding this comment.
Thank you! My only comment is about typing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #113 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 896 901 +5
=========================================
+ Hits 896 901 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Created `src/pyextremes/typing.py` with `PoolType` Protocol. - Updated `src/pyextremes/eva.py` to use `PoolType` in `fit_model` overload. - Updated `src/pyextremes/models/model_emcee.py` to use `PoolType` in `__init__` and `fit`. - Updated `src/pyextremes/models/models.py` to use `PoolType` in `get_model` overload. - Ran ruff and pytest.
Contributor
Author
|
Hi @georgebv , thanks for your review and comments. I've updated the codebase based on your feedback. Please let me know if the changes are correct for you now. |
georgebv
reviewed
Feb 17, 2026
- Delete [src/pyextremes/typing.py] to simplify package structure. - Move [PoolType] protocol to [src/pyextremes/models/model_emcee.py] where it is primarily utilized. - Update internal imports in [src/pyextremes/models/models.py] and [src/pyextremes/eva.py]. - Ensure PEP 8/20 compliance by co-locating typing definitions with their primary consumers.
georgebv
previously approved these changes
Feb 18, 2026
Owner
|
@jultou-raa looks like the linter is complaining, we should be good to merge once it passes |
Contributor
Author
Sorry I did not activate the select I option when I checked. Now test should pass. |
georgebv
approved these changes
Feb 19, 2026
Owner
|
@jultou-raa thank you, released in https://github.com/georgebv/pyextremes/releases/tag/v2.5.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the
poolparameter in theEmceemodel, allowing users to leverage parallel processing capabilities ofemcee.EnsembleSampler.This enhancement enables faster chain computations, which is beneficial for large datasets or complex models.
Changes:
src/pyextremes/models/model_emcee.py: UpdatedEmceeclass to acceptpoolargument in__init__and pass it toemcee.EnsembleSamplerinfit.src/pyextremes/models/models.py: Updatedget_modelfunction signature and docstring.src/pyextremes/eva.py: UpdatedEVA.fit_modelmethod signature and docstring.tests/models/test_model_emcee.py: Added a test casetest_fit_with_poolto ensurepoolis correctly passed to the sampler.ruffand ensured PEP8 compliance.Fixes #95