src/cyw43_ctrl: Fix STA teardown to deinit tcpip & clear itf_state.#145
Merged
dpgeorge merged 1 commit intogeorgerobotics:mainfrom Feb 20, 2026
Merged
src/cyw43_ctrl: Fix STA teardown to deinit tcpip & clear itf_state.#145dpgeorge merged 1 commit intogeorgerobotics:mainfrom
dpgeorge merged 1 commit intogeorgerobotics:mainfrom
Conversation
Previously the deactivate branch of cyw43_wifi_set_up() only handled AP teardown. Deactivating STA left itf_state bit 0 set and skipped cyw43_cb_tcpip_deinit(), so re-activating STA after AP mode would not call cyw43_cb_tcpip_init() or netif_set_default(), causing EHOSTUNREACH. Signed-off-by: Praful Mathur <praful.mathur@gmail.com>
dpgeorge
approved these changes
Feb 20, 2026
dpgeorge
left a comment
dpgeorge
left a comment
There was a problem hiding this comment.
Thanks for this, this is the right fix.
I tested on RPI_PICO2_W and PYBD_SF6 and did not see any issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the deactivate branch of cyw43_wifi_set_up() only handled AP teardown.
Deactivating STA left itf_state bit 0 set and skipped cyw43_cb_tcpip_deinit(), so re-activating STA after AP mode would not call cyw43_cb_tcpip_init() or netif_set_default(), causing EHOSTUNREACH.