Implement a multicast filtering api and enable v6 for lwip#24
Merged
dpgeorge merged 3 commits intogeorgerobotics:mainfrom Dec 9, 2022
Merged
Implement a multicast filtering api and enable v6 for lwip#24dpgeorge merged 3 commits intogeorgerobotics:mainfrom
dpgeorge merged 3 commits intogeorgerobotics:mainfrom
Conversation
This was referenced Aug 25, 2022
Contributor
Author
Collaborator
|
There are a couple of other changes I'd like with these IPV6 changes, pushed on here https://github.com/peterharperuk/cyw43-driver/commits/ipv6 |
Contributor
Author
|
perfect, thank you. I've just tested the changed version on my board and it works perfectly. Should I now fast-forward this PR to include your changes or how do we get them merged? |
Collaborator
|
It might be nice if you can pull all the changes into this one merge request and reference this issue #18? |
This was referenced Nov 22, 2022
peterharperuk
approved these changes
Dec 6, 2022
Collaborator
peterharperuk
left a comment
peterharperuk
left a comment
There was a problem hiding this comment.
Tested again - still works
Contributor
Author
Prior to this commit the build would fail if LWIP_IPV4 is not true. cyw43_tcpip_link_status only returns link up if we have a valid global IPv6 address.
|
Thanks for rebasing, this looks good. I will do some very minor code style fixes during merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #19 should resolve #18.
Thanks to the good hint in from @peterharperuk #18 (comment) I was able to use the mac address filtering. With these changes applied, ipv6 works perfectly for me.
And hints? Should I split up the 2 commits into to separate PRs?