Include dependencies and let some code more readable#67
Open
silviolleite wants to merge 4 commits intogeorgeyk:masterfrom
Open
Include dependencies and let some code more readable#67silviolleite wants to merge 4 commits intogeorgeyk:masterfrom
silviolleite wants to merge 4 commits intogeorgeyk:masterfrom
Conversation
georgeyk
reviewed
Aug 5, 2020
georgeyk
reviewed
Aug 5, 2020
| pytest-asyncio | ||
| pytest-cov | ||
| pytest-deadfixtures | ||
| pytest-runner |
Owner
There was a problem hiding this comment.
Can you give me more context about this?
Author
There was a problem hiding this comment.
It's required on setup.py at line 91
python setup_requires=['pytest-runner'],
The IDE show an warnning Package requirement 'pytest-runner' is not satisfied.
Owner
There was a problem hiding this comment.
I think it's your IDE, I could not find anything in regular environments or circleci. Please revert this change.
Owner
|
hey @silviolleite thanks for your collaboration. |
georgeyk
reviewed
Aug 17, 2020
|
|
||
| if hasattr(self, '_future'): | ||
| future = getattr(self, '_future', None) | ||
| if future: |
Owner
There was a problem hiding this comment.
I don't see any problem with readability here.
georgeyk
reviewed
Aug 17, 2020
| logger.info('error handler process originated by message={}'.format(message)) | ||
|
|
||
| if self._error_handler is not None: | ||
| if self._error_handler: |
georgeyk
reviewed
Aug 17, 2020
| raise ValueError('{} failed to translate message={}'.format(self.message_translator, message)) | ||
|
|
||
| return processed_message | ||
| return translated |
Owner
There was a problem hiding this comment.
This might override metadata values if we apply the translator several times. I'll check and then we can improve this on the side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
apply_message_translatorfunction more readableCongratulations! Great lib 🥇